Skip to content

fix(confirmations): submit money account withdrawals on Monad - #45563

Draft
jpuri wants to merge 1 commit into
fix/confirmations-money-account-deposit-submitfrom
fix/confirmations-money-account-withdraw-submit
Draft

fix(confirmations): submit money account withdrawals on Monad#45563
jpuri wants to merge 1 commit into
fix/confirmations-money-account-deposit-submitfrom
fix/confirmations-money-account-withdraw-submit

Conversation

@jpuri

@jpuri jpuri commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Description

Make money-account withdrawals (including the default same-token mUSD on Monad path) actually move funds, mirroring the mobile implementation:

  • Treat the Money Keyring as EIP-7702-relay capable. Sponsored withdrawals are externally signed and must publish via the sentinel relay; skipping the relay hook raw-sent an unsigned payload that Monad rejected with "Transaction decoding error".
  • Relay the parent execute() as a single exactExecution delegation like mobile's publish hook, instead of expanding nestedTransactions into a batch redeem that mined without moving funds.
  • Throw (like mobile) when a sponsored or gas-included transaction lands on a chain without EIP-7702 support instead of silently falling through to the unsigned raw send.
  • Approve only funded withdraw batches: re-encode the typed amount at confirm, rebuild the parent batch calldata from the funded nested calls, and log why a submit was refused instead of silently no-oping.
  • Hide result rows for zero withdraw amounts even when a no-op quote is stored.

Changelog

CHANGELOG entry: Fixed money account withdrawals not submitting on Monad

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/CONF-1816

Manual testing steps

  1. Open a confirmation for a money account withdrawal (mUSD on Monad)
  2. Enter a withdraw amount and confirm
  3. Verify the transaction is submitted via the relay and funds actually move
  4. Verify a zero withdraw amount hides the result rows and the confirm is blocked

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

🤖 Generated with Claude Code

@jpuri
jpuri deployed to pr-comment August 17, 2026 04:31 — with GitHub Actions Active
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamask-ci metamask-ci Bot added the team-confirmations Push issues to confirmations team label Aug 17, 2026
@metamask-ci

metamask-ci Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

@MetaMask/confirmations (43 files, +2274 -181)
  • 📁 app/
    • 📁 scripts/
      • 📁 lib/
        • 📁 transaction/
          • 📁 hooks/
            • 📄 delegation-7702-publish.test.ts +78 -0
            • 📄 delegation-7702-publish.ts +23 -4
            • 📄 delegation.test.ts +50 -0
            • 📄 delegation.ts +13 -1
  • 📁 ui/
    • 📁 pages/
      • 📁 confirmations/
        • 📁 components/
          • 📁 activity/
            • 📁 transaction-details-hero/
              • 📄 transaction-details-hero.test.tsx +64 -6
              • 📄 transaction-details-hero.tsx +40 -4
          • 📁 confirm/
            • 📁 footer/
              • 📄 footer.test.tsx +1 -0
              • 📄 single-action-footer.test.tsx +122 -5
              • 📄 single-action-footer.tsx +81 -10
          • 📁 developer/
            • 📁 money-account-withdraw-button/
              • 📄 messenger.ts +13 -0
              • 📄 money-account-withdraw-button.test.tsx +48 -33
              • 📄 money-account-withdraw-button.tsx +37 -13
          • 📁 info/
            • 📁 custom-amount-info/
              • 📄 custom-amount-info.test.tsx +34 -0
              • 📄 custom-amount-info.tsx +37 -14
          • 📁 modals/
            • 📁 pay-with-modal/
              • 📄 pay-with-modal.test.tsx +12 -0
              • 📄 pay-with-modal.tsx +5 -2
          • 📁 rows/
            • 📁 from-account-row/
              • 📄 from-account-row.test.tsx +44 -0
              • 📄 from-account-row.tsx +12 -1
        • 📁 hooks/
          • 📁 alerts/
            • 📁 transactions/
              • 📄 useInsufficientBalanceAlerts.test.ts +2 -2
              • 📄 useInsufficientBalanceAlerts.ts +7 -4
              • 📄 useInsufficientMoneyAccountBalanceAlert.test.ts +205 -0
              • 📄 useInsufficientMoneyAccountBalanceAlert.ts +117 -0
              • 📄 constants.ts +1 -0
          • 📁 gas/
            • 📄 useIsGaslessLoading.test.ts +23 -6
            • 📄 useIsGaslessLoading.ts +14 -1
          • 📁 pay/
            • 📄 useIsPaidByMetaMask.test.ts +22 -0
            • 📄 useIsPaidByMetaMask.ts +17 -5
            • 📄 usePayWithNoFeeToken.test.tsx +60 -0
            • 📄 usePayWithNoFeeToken.tsx +38 -7
          • 📁 transactions/
            • 📄 useLastMoneyAccountWithdrawAmount.test.ts +46 -0
            • 📄 useLastMoneyAccountWithdrawAmount.ts +21 -0
            • 📄 useTransactionConfirm.test.ts +243 -2
            • 📄 useTransactionConfirm.ts +324 -49
            • 📄 useTransactionCustomAmount.test.ts +51 -0
            • 📄 useTransactionCustomAmount.ts +31 -4
            • 📄 useTransactionCustomAmountAlerts.test.ts +25 -0
            • 📄 useTransactionCustomAmountAlerts.ts +1 -0
            • 📄 useUpdateTokenAmount.test.ts +54 -3
            • 📄 useUpdateTokenAmount.ts +11 -4
            • 📄 useConfirmationAlerts.test.ts +4 -0
            • 📄 useConfirmationAlerts.ts +5 -0
        • 📁 utils/
          • 📄 transaction-pay.test.ts +168 -0
          • 📄 transaction-pay.ts +70 -1

@jpuri jpuri added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Aug 17, 2026
@jpuri
jpuri force-pushed the fix/confirmations-money-account-deposit-submit branch from f7594c7 to 4d93f51 Compare August 17, 2026 10:05
@jpuri
jpuri force-pushed the fix/confirmations-money-account-withdraw-submit branch from eb55e66 to 9a9a1c7 Compare August 17, 2026 10:13
@jpuri
jpuri deployed to pr-comment August 17, 2026 10:13 — with GitHub Actions Active
@jpuri
jpuri force-pushed the fix/confirmations-money-account-deposit-submit branch from 4d93f51 to f87e910 Compare August 20, 2026 17:15
@jpuri
jpuri force-pushed the fix/confirmations-money-account-withdraw-submit branch from 9a9a1c7 to 4833818 Compare August 20, 2026 17:15
@jpuri
jpuri deployed to pr-comment August 20, 2026 17:15 — with GitHub Actions Active
@jpuri
jpuri deployed to pr-comment August 20, 2026 17:38 — with GitHub Actions Active
@metamask-ci

metamask-ci Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor
Builds ready [4833818]
⚡ Performance Benchmarks (Total: 🟢 13 pass · 🟡 8 warn · 🔴 3 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 32396630513 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🔴 bridge_load_page

📈 Results compared to the previous 5 runs on main

  • loadNewAccount/load_new_account: +189%
  • loadNewAccount/total: +189%
  • loadNewAccount/inp: +29%
  • confirmTx/longTaskTotalDuration: -12%
  • confirmTx/longTaskMaxDuration: +40%
  • confirmTx/tbt: -21%
  • bridgeUserActions/bridge_load_asset_picker: +24%
  • bridgeUserActions/longTaskCount: +11%
  • bridgeUserActions/longTaskTotalDuration: -16%
  • bridgeUserActions/longTaskMaxDuration: -28%
  • bridgeUserActions/tbt: -70%
  • loadNewAccount/load_new_account: +195%
  • loadNewAccount/total: +195%
  • loadNewAccount/inp: +21%
  • loadNewAccount/fcp: -49%
  • loadNewAccount/lcp: +1228%
  • confirmTx/longTaskCount: -100%
  • confirmTx/longTaskTotalDuration: -100%
  • confirmTx/longTaskMaxDuration: -100%
  • confirmTx/tbt: -100%
  • confirmTx/inp: -17%
  • confirmTx/fcp: -46%
  • confirmTx/lcp: +1211%
  • bridgeUserActions/bridge_load_page: +2018%
  • bridgeUserActions/bridge_load_asset_picker: +131%
  • bridgeUserActions/longTaskCount: -100%
  • bridgeUserActions/longTaskTotalDuration: -100%
  • bridgeUserActions/longTaskMaxDuration: -100%
  • bridgeUserActions/tbt: -100%
  • bridgeUserActions/total: +207%
  • bridgeUserActions/lcp: +1124%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.8s
  • 🟡 confirmTx/FCP: p75 1.8s
  • 🟡 bridgeUserActions/FCP: p75 1.8s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
startupPowerUserHome
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • startupStandardHome/firstReactRender: -99%
  • startupStandardHome/setupStore: +59%
  • startupStandardHome/numNetworkReqs: -14%
  • startupStandardHome/uiStartup: -11%
  • startupStandardHome/domInteractive: -13%
  • startupStandardHome/firstReactRender: -98%
  • startupStandardHome/setupStore: +13%
  • startupStandardHome/numNetworkReqs: -20%
  • startupPowerUserHome/uiStartup: -23%
  • startupPowerUserHome/domInteractive: -52%
  • startupPowerUserHome/backgroundConnect: -32%
  • startupPowerUserHome/firstReactRender: -99%
  • startupPowerUserHome/initialActions: +11%
  • startupPowerUserHome/setupStore: -73%
  • startupPowerUserHome/numNetworkReqs: -44%
  • startupPowerUserHome/inp: -11%
  • startupPowerUserHome/fcp: -50%
  • startupPowerUserHome/lcp: -14%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
assetDetails
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
importSrpHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
sendTransactions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
swap
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • onboardingImportWallet/pwFormToMetricsScreen: -16%
  • onboardingImportWallet/metricsToWalletReadyScreen: -12%
  • onboardingImportWallet/doneButtonToHomeScreen: -92%
  • onboardingImportWallet/openAccountMenuToAccountListLoaded: -69%
  • onboardingImportWallet/longTaskCount: -100%
  • onboardingImportWallet/longTaskTotalDuration: -100%
  • onboardingImportWallet/longTaskMaxDuration: -100%
  • onboardingImportWallet/tbt: -100%
  • onboardingImportWallet/total: -86%
  • onboardingNewWallet/srpButtonToPwForm: +24%
  • onboardingNewWallet/createPwToRecoveryScreen: +10%
  • onboardingNewWallet/skipBackupToMetricsScreen: +31%
  • onboardingNewWallet/agreeButtonToOnboardingSuccess: +13%
  • onboardingNewWallet/doneButtonToAssetList: -81%
  • onboardingNewWallet/longTaskCount: -69%
  • onboardingNewWallet/longTaskTotalDuration: -76%
  • onboardingNewWallet/longTaskMaxDuration: -44%
  • onboardingNewWallet/tbt: -90%
  • onboardingNewWallet/total: -77%
  • solanaAssetDetails/assetClickToPriceChart: +261%
  • solanaAssetDetails/longTaskCount: -100%
  • solanaAssetDetails/longTaskTotalDuration: -100%
  • solanaAssetDetails/longTaskMaxDuration: -100%
  • solanaAssetDetails/tbt: -100%
  • solanaAssetDetails/total: +261%
  • solanaAssetDetails/fcp: +17%
  • importSrpHome/loginToHomeScreen: -36%
  • importSrpHome/homeAfterImportWithNewWallet: -58%
  • importSrpHome/longTaskCount: -58%
  • importSrpHome/longTaskTotalDuration: -64%
  • importSrpHome/longTaskMaxDuration: -48%
  • importSrpHome/tbt: -70%
  • importSrpHome/total: -55%
  • importSrpHome/inp: -56%
  • importSrpHome/fcp: -12%
  • importSrpHome/lcp: -27%
  • importSrpHome/cls: +443%
  • sendTransactions/openSendPageFromHome: -15%
  • sendTransactions/selectTokenToSendFormLoaded: +57%
  • sendTransactions/reviewTransactionToConfirmationPage: -98%
  • sendTransactions/longTaskCount: -100%
  • sendTransactions/longTaskTotalDuration: -100%
  • sendTransactions/longTaskMaxDuration: -100%
  • sendTransactions/tbt: -100%
  • sendTransactions/total: -95%
  • sendTransactions/inp: -44%
  • sendTransactions/lcp: -61%
  • sendTransactions/cls: +171%
  • swap/openSwapPageFromHome: +800%
  • swap/fetchAndDisplaySwapQuotes: +87%
  • swap/longTaskCount: +33%
  • swap/longTaskTotalDuration: -16%
  • swap/longTaskMaxDuration: -12%
  • swap/tbt: -100%
  • swap/total: +102%
  • swap/lcp: -69%
  • swap/cls: -92%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 assetDetails/FCP: p75 1.8s
  • 🟡 solanaAssetDetails/FCP: p75 1.8s
  • 🟡 assetDetails/FCP: p75 1.9s
  • 🟡 solanaAssetDetails/FCP: p75 1.9s
  • 🟡 sendTransactions/FCP: p75 2.0s
  • 🔴 swap/INP: p75 800ms
  • 🟡 swap/FCP: p75 1.9s
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • dappPageLoad/pageLoadTime: -56%
  • dappPageLoad/firstPaint: -37%
  • dappPageLoad/firstContentfulPaint: -37%
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 121.79 KiB (0.83%)
  • ui: 34.64 KiB (0.18%)
  • common: 0 Bytes (0%)
  • other: 0 Bytes (0%)
  • contentScripts: 9 KiB (0.47%)
  • zip: 45.03 KiB (0.2%)

@jpuri
jpuri deployed to pr-comment August 20, 2026 18:02 — with GitHub Actions Active
@jpuri
jpuri deployed to pr-comment August 20, 2026 18:03 — with GitHub Actions Active
@jpuri
jpuri deployed to pr-comment August 20, 2026 18:11 — with GitHub Actions Active
@jpuri
jpuri deployed to pr-comment August 20, 2026 18:34 — with GitHub Actions Active
@jpuri
jpuri deployed to pr-comment August 20, 2026 18:52 — with GitHub Actions Active
@jpuri
jpuri force-pushed the fix/confirmations-money-account-deposit-submit branch from 4891fe6 to e644871 Compare August 20, 2026 19:11
@jpuri
jpuri deployed to pr-comment August 20, 2026 19:12 — with GitHub Actions Active
@metamask-ci

metamask-ci Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor
Builds ready [90edbf6] [reused from efee728]
⚡ Performance Benchmarks (Total: 🟢 14 pass · 🟡 6 warn · 🔴 3 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 32405568487 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🔴 srpButtonToPwForm(p95) [CI log]🟡 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • loadNewAccount/load_new_account: +191%
  • loadNewAccount/total: +191%
  • loadNewAccount/inp: -17%
  • loadNewAccount/fcp: -19%
  • loadNewAccount/lcp: -15%
  • confirmTx/longTaskCount: -33%
  • confirmTx/longTaskTotalDuration: -41%
  • confirmTx/tbt: -60%
  • confirmTx/inp: -17%
  • confirmTx/fcp: -22%
  • confirmTx/lcp: -17%
  • bridgeUserActions/bridge_load_page: -12%
  • bridgeUserActions/longTaskCount: -44%
  • bridgeUserActions/longTaskTotalDuration: -45%
  • bridgeUserActions/longTaskMaxDuration: -15%
  • bridgeUserActions/tbt: -45%
  • bridgeUserActions/fcp: -29%
  • bridgeUserActions/lcp: -17%
  • loadNewAccount/load_new_account: +193%
  • loadNewAccount/total: +193%
  • loadNewAccount/inp: -24%
  • loadNewAccount/fcp: -52%
  • loadNewAccount/lcp: +1596%
  • confirmTx/longTaskCount: -100%
  • confirmTx/longTaskTotalDuration: -100%
  • confirmTx/longTaskMaxDuration: -100%
  • confirmTx/tbt: -100%
  • confirmTx/inp: -24%
  • confirmTx/fcp: -43%
  • confirmTx/lcp: +1221%
  • bridgeUserActions/bridge_load_page: +161%
  • bridgeUserActions/bridge_load_asset_picker: +243%
  • bridgeUserActions/bridge_search_token: +19%
  • bridgeUserActions/longTaskCount: -100%
  • bridgeUserActions/longTaskTotalDuration: -100%
  • bridgeUserActions/longTaskMaxDuration: -100%
  • bridgeUserActions/tbt: -100%
  • bridgeUserActions/total: +26%
  • bridgeUserActions/fcp: +11%
  • bridgeUserActions/lcp: +1174%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/LCP: p75 3.0s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
Startup Benchmarks · Samples: 100

⚠️ Missing data: firefox/webpack/startupPowerUserHome

Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • startupStandardHome/firstReactRender: -99%
  • startupStandardHome/setupStore: +36%
  • startupStandardHome/numNetworkReqs: -14%
  • startupStandardHome/uiStartup: -28%
  • startupStandardHome/load: -22%
  • startupStandardHome/domContentLoaded: -21%
  • startupStandardHome/domInteractive: +11%
  • startupStandardHome/backgroundConnect: -17%
  • startupStandardHome/firstReactRender: -99%
  • startupStandardHome/initialActions: -50%
  • startupStandardHome/loadScripts: -22%
  • startupStandardHome/setupStore: -14%
  • startupStandardHome/numNetworkReqs: -20%
  • startupStandardHome/fcp: +13%
  • startupStandardHome/lcp: -19%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟡 [CI log]
🟡 total
🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🔴 [CI log]
🔴 total
🟡 [CI log]
🟡 total
assetDetails
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
importSrpHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
sendTransactions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
swap
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • onboardingImportWallet/doneButtonToHomeScreen: -92%
  • onboardingImportWallet/openAccountMenuToAccountListLoaded: -56%
  • onboardingImportWallet/longTaskCount: -100%
  • onboardingImportWallet/longTaskTotalDuration: -100%
  • onboardingImportWallet/longTaskMaxDuration: -100%
  • onboardingImportWallet/tbt: -100%
  • onboardingImportWallet/total: -83%
  • onboardingNewWallet/srpButtonToPwForm: +30%
  • onboardingNewWallet/createPwToRecoveryScreen: +18%
  • onboardingNewWallet/skipBackupToMetricsScreen: +27%
  • onboardingNewWallet/agreeButtonToOnboardingSuccess: +11%
  • onboardingNewWallet/longTaskCount: -69%
  • onboardingNewWallet/longTaskTotalDuration: -68%
  • onboardingNewWallet/longTaskMaxDuration: -45%
  • onboardingNewWallet/tbt: -91%
  • solanaAssetDetails/assetClickToPriceChart: +216%
  • solanaAssetDetails/longTaskCount: -100%
  • solanaAssetDetails/longTaskTotalDuration: -100%
  • solanaAssetDetails/longTaskMaxDuration: -100%
  • solanaAssetDetails/tbt: -100%
  • solanaAssetDetails/total: +216%
  • solanaAssetDetails/lcp: -16%
  • importSrpHome/loginToHomeScreen: -15%
  • importSrpHome/homeAfterImportWithNewWallet: -33%
  • importSrpHome/longTaskCount: -58%
  • importSrpHome/longTaskTotalDuration: -63%
  • importSrpHome/longTaskMaxDuration: -35%
  • importSrpHome/tbt: -61%
  • importSrpHome/total: -29%
  • importSrpHome/inp: -48%
  • importSrpHome/lcp: -14%
  • importSrpHome/cls: +443%
  • sendTransactions/openSendPageFromHome: -29%
  • sendTransactions/selectTokenToSendFormLoaded: -16%
  • sendTransactions/reviewTransactionToConfirmationPage: -98%
  • sendTransactions/longTaskCount: -100%
  • sendTransactions/longTaskTotalDuration: -100%
  • sendTransactions/longTaskMaxDuration: -100%
  • sendTransactions/tbt: -100%
  • sendTransactions/total: -94%
  • sendTransactions/inp: -48%
  • sendTransactions/lcp: -61%
  • sendTransactions/cls: +171%
  • swap/openSwapPageFromHome: +157%
  • swap/fetchAndDisplaySwapQuotes: +86%
  • swap/longTaskCount: +33%
  • swap/tbt: -68%
  • swap/total: +86%
  • swap/lcp: -70%
  • swap/cls: -92%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 importSrpHome/FCP: p75 1.8s
  • 🟡 sendTransactions/FCP: p75 1.9s
  • 🔴 swap/INP: p75 760ms
  • 🟡 swap/FCP: p75 1.9s
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • dappPageLoad/pageLoadTime: -58%
  • dappPageLoad/firstPaint: -46%
  • dappPageLoad/firstContentfulPaint: -46%
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 121.79 KiB (0.83%)
  • ui: 34.76 KiB (0.18%)
  • common: 0 Bytes (0%)
  • other: 0 Bytes (0%)
  • contentScripts: 9 KiB (0.47%)
  • zip: 45.04 KiB (0.2%)

@jpuri
jpuri force-pushed the fix/confirmations-money-account-withdraw-submit branch from 90edbf6 to f01e354 Compare August 20, 2026 19:13
@jpuri
jpuri deployed to pr-comment August 20, 2026 19:13 — with GitHub Actions Active
@jpuri
jpuri deployed to pr-comment August 20, 2026 19:38 — with GitHub Actions Active
@metamask-ci

metamask-ci Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor
Builds ready [f01e354]
⚡ Performance Benchmarks (Total: 🟢 13 pass · 🟡 7 warn · 🔴 3 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 32407547128 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🔴 srpButtonToSrpForm(p95) [CI log]🟢 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • loadNewAccount/load_new_account: +189%
  • loadNewAccount/total: +189%
  • confirmTx/longTaskTotalDuration: -14%
  • confirmTx/longTaskMaxDuration: +39%
  • confirmTx/tbt: -24%
  • bridgeUserActions/bridge_load_asset_picker: +40%
  • bridgeUserActions/longTaskCount: -44%
  • bridgeUserActions/longTaskTotalDuration: -56%
  • bridgeUserActions/longTaskMaxDuration: -31%
  • bridgeUserActions/tbt: -77%
  • bridgeUserActions/inp: +15%
  • loadNewAccount/load_new_account: +191%
  • loadNewAccount/total: +191%
  • loadNewAccount/inp: +36%
  • loadNewAccount/lcp: +1099%
  • confirmTx/longTaskCount: -100%
  • confirmTx/longTaskTotalDuration: -100%
  • confirmTx/longTaskMaxDuration: -100%
  • confirmTx/tbt: -100%
  • confirmTx/inp: -24%
  • confirmTx/fcp: -44%
  • confirmTx/lcp: +1284%
  • bridgeUserActions/bridge_load_page: +159%
  • bridgeUserActions/bridge_load_asset_picker: +212%
  • bridgeUserActions/bridge_search_token: +34%
  • bridgeUserActions/longTaskCount: -100%
  • bridgeUserActions/longTaskTotalDuration: -100%
  • bridgeUserActions/longTaskMaxDuration: -100%
  • bridgeUserActions/tbt: -100%
  • bridgeUserActions/total: +63%
  • bridgeUserActions/inp: +15%
  • bridgeUserActions/fcp: -46%
  • bridgeUserActions/lcp: +1084%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 confirmTx/FCP: p75 1.8s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
startupPowerUserHome
[Sentry log · main/release]
🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • startupStandardHome/firstPaint: +12%
  • startupStandardHome/firstReactRender: -99%
  • startupStandardHome/setupStore: +29%
  • startupStandardHome/numNetworkReqs: -14%
  • startupStandardHome/lcp: +12%
  • startupStandardHome/domInteractive: -11%
  • startupStandardHome/firstReactRender: -98%
  • startupStandardHome/setupStore: +13%
  • startupStandardHome/numNetworkReqs: -20%
  • startupPowerUserHome/uiStartup: -11%
  • startupPowerUserHome/domInteractive: -47%
  • startupPowerUserHome/backgroundConnect: -23%
  • startupPowerUserHome/firstReactRender: -99%
  • startupPowerUserHome/initialActions: +11%
  • startupPowerUserHome/setupStore: -75%
  • startupPowerUserHome/numNetworkReqs: -31%
  • startupPowerUserHome/fcp: -45%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 startupPowerUserHome/LCP: p75 2.8s
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🔴 [CI log]
🔴 total
🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]
🔴 total
🟢 [CI log]
assetDetails
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
importSrpHome
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
sendTransactions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
swap
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • onboardingImportWallet/srpButtonToSrpForm: +33%
  • onboardingImportWallet/confirmSrpToPwForm: +38%
  • onboardingImportWallet/pwFormToMetricsScreen: +19%
  • onboardingImportWallet/metricsToWalletReadyScreen: +35%
  • onboardingImportWallet/doneButtonToHomeScreen: -92%
  • onboardingImportWallet/openAccountMenuToAccountListLoaded: -43%
  • onboardingImportWallet/longTaskCount: -86%
  • onboardingImportWallet/longTaskTotalDuration: -96%
  • onboardingImportWallet/longTaskMaxDuration: -91%
  • onboardingImportWallet/tbt: -100%
  • onboardingImportWallet/total: -79%
  • onboardingNewWallet/srpButtonToPwForm: +29%
  • onboardingNewWallet/createPwToRecoveryScreen: +17%
  • onboardingNewWallet/skipBackupToMetricsScreen: +28%
  • onboardingNewWallet/agreeButtonToOnboardingSuccess: +23%
  • onboardingNewWallet/longTaskCount: -69%
  • onboardingNewWallet/longTaskTotalDuration: -77%
  • onboardingNewWallet/longTaskMaxDuration: -40%
  • onboardingNewWallet/tbt: -85%
  • solanaAssetDetails/assetClickToPriceChart: +246%
  • solanaAssetDetails/longTaskCount: -100%
  • solanaAssetDetails/longTaskTotalDuration: -100%
  • solanaAssetDetails/longTaskMaxDuration: -100%
  • solanaAssetDetails/tbt: -100%
  • solanaAssetDetails/total: +246%
  • solanaAssetDetails/inp: -13%
  • solanaAssetDetails/lcp: -18%
  • importSrpHome/loginToHomeScreen: -19%
  • importSrpHome/longTaskCount: -30%
  • importSrpHome/longTaskTotalDuration: -42%
  • importSrpHome/longTaskMaxDuration: -42%
  • importSrpHome/tbt: -54%
  • importSrpHome/inp: -33%
  • importSrpHome/cls: +467%
  • sendTransactions/openSendPageFromHome: -34%
  • sendTransactions/selectTokenToSendFormLoaded: +17%
  • sendTransactions/reviewTransactionToConfirmationPage: -98%
  • sendTransactions/longTaskCount: -100%
  • sendTransactions/longTaskTotalDuration: -100%
  • sendTransactions/longTaskMaxDuration: -100%
  • sendTransactions/tbt: -100%
  • sendTransactions/total: -95%
  • sendTransactions/inp: -48%
  • sendTransactions/lcp: -66%
  • sendTransactions/cls: +171%
  • swap/fetchAndDisplaySwapQuotes: +87%
  • swap/longTaskCount: -100%
  • swap/longTaskTotalDuration: -100%
  • swap/longTaskMaxDuration: -100%
  • swap/tbt: -100%
  • swap/total: +90%
  • swap/lcp: -73%
  • swap/cls: -92%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 importSrpHome/INP: p75 208ms
  • 🟡 assetDetails/FCP: p75 1.9s
  • 🟡 solanaAssetDetails/FCP: p75 1.9s
  • 🟡 importSrpHome/FCP: p75 2.0s
  • 🟡 swap/INP: p75 368ms
Dapp Page Load Benchmarks · Samples: 100

⚠️ Missing data: chrome/webpack/pageLoadBenchmark

✅ No regressions detected

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 122.11 KiB (0.84%)
  • ui: 34.68 KiB (0.18%)
  • common: 0 Bytes (0%)
  • other: 0 Bytes (0%)
  • contentScripts: 9 KiB (0.47%)
  • zip: 45.05 KiB (0.2%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed size-XL team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant